Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing thrown errors fixed the closing problem #2425

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fixing thrown errors fixed the closing problem #2425

merged 1 commit into from
Oct 11, 2024

Conversation

scytacki
Copy link
Member

@scytacki scytacki commented Oct 8, 2024 •
edited
Loading

  • some linked tiles had empty string ids, so this caused react to complain about duplicate keys
  • the geometry board couldn't be destroyed, the uncaught exception prevented React from re-rendering the sort work tab

PT-188339926

@scytacki
fixing thrown errors fixed the closing problem
6d42755 
- some linked tiles had empty string ids, so this caused react to complain about duplicate keys
- the geometry board couldn't be destroyed, the uncaught exception prevented React from re-rendering the sort work tab
@cypress Cypress
Copy link

cypress bot commented Oct 8, 2024 •
edited
Loading

collaborative-learning    Run #13987

Run Properties:  status check passed Passed #13987  •  git commit 6d427551e5: fixing thrown errors fixed the closing problem
Project collaborative-learning
Run status status check passed Passed #13987
Run duration 14m 37s
Commit git commit 6d427551e5: fixing thrown errors fixed the closing problem
Committer Scott Cytacki
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 112

@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.27%. Comparing base (8bef86c) to head (6d42755).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
src/components/tiles/geometry/geometry-content.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2425      +/-   ##
==========================================
+ Coverage   85.38%   86.27%   +0.89%     
==========================================
  Files         742      742              
  Lines       38379    38382       +3     
  Branches     9801     9802       +1     
==========================================
+ Hits        32769    33115     +346     
+ Misses       5304     4967     -337     
+ Partials      306      300       -6
Flag Coverage Δ
cypress-regression 78.09% <85.71%> (+1.43%) ⬆️
cypress-smoke 27.96% <71.42%> (+<0.01%) ⬆️
jest 48.86% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scytacki scytacki marked this pull request as ready for review October 9, 2024 12:39
bgoldowsky
bgoldowsky approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@bgoldowsky bgoldowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@scytacki scytacki merged commit 7be444b into master Oct 11, 2024
19 checks passed
@scytacki scytacki deleted the 188339926-documents-fail-to-close branch October 11, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgoldowsky bgoldowsky bgoldowsky approved these changes

Assignees
No one assigned
Labels
run regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scytacki @bgoldowsky